Move all scss @import to @use/@forward#1697
Merged
sachinchoolur merged 1 commit intosachinchoolur:scss-usefrom Jun 15, 2025
Merged
Move all scss @import to @use/@forward#1697sachinchoolur merged 1 commit intosachinchoolur:scss-usefrom
sachinchoolur merged 1 commit intosachinchoolur:scss-usefrom
Conversation
|
@sachinchoolur and @joeworkman when will this be merged? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
Author
|
@eat-sleep-code Not my decision. Sorry. You can pull down the version from this pull request though. |
Owner
|
Thanks @joeworkman, Changes are now available in version 2.9.0-beta.1 |
|
This worked! At first I thought it didn't, but it was just NPM being a bit problematic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update migrates all sass to the new
@use/@forwardfrom the deprecated@import. It also uses thesass:listmodule for various functions. I have verified that this build generates the same exact CSS asv2.8.2.I would consider this a breaking change. With some simple setups that do not override SCSS variables, existing setups might work. However, here is an example of my test setup that I needed to get this version working.
This first line is important so that the variables can be overwritten before you load in lightgallery and plugins.
Fixes #1677
Fixes #1647